Use constants for token start/end symbols #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattcoley
reviewed
Feb 21, 2019
| private String reconstructImage() { | ||
| StringBuilder builder = new StringBuilder().append(master.getImage()); | ||
|
|
||
| for (Node n : getChildren()) { | ||
| builder.append(n.getMaster().getImage()); | ||
| } | ||
|
|
||
| builder.append("{% ").append(getEndName()). append(" %}"); | ||
| builder.append(TokenScannerSymbols.TOKEN_EXPR_START).append(TokenScannerSymbols.TOKEN_TAG).append(" ") |
There was a problem hiding this comment.
Can we make this just one append with a String.format for readability? The StringBuilder makes sense for the above code however makes this bit hard to read.
There was a problem hiding this comment.
Sure, done. I think it's a bit better now.
Codecov Report
@@ Coverage Diff @@
## master #285 +/- ##
============================================
+ Coverage 72.28% 72.32% +0.03%
Complexity 1497 1497
============================================
Files 234 234
Lines 4648 4654 +6
Branches 739 739
============================================
+ Hits 3360 3366 +6
Misses 1033 1033
Partials 255 255
Continue to review full report at Codecov.
|
jboulter
reviewed
Feb 21, 2019
| int TOKEN_EXPR_START = '{'; | ||
| int TOKEN_EXPR_END = '}'; | ||
| int TOKEN_NEWLINE = '\n'; | ||
| char TOKEN_PREFIX_CHAR = '{'; |
There was a problem hiding this comment.
for convenience it might be nice to have constants for {%, %}, {{ and }}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I forgot to include this change in my previous PR: #282