Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix create-react-class and prop-types references in UMD build #87

Closed
wants to merge 1 commit into from
Closed

Fix create-react-class and prop-types references in UMD build #87

wants to merge 1 commit into from

Conversation

banderson
Copy link
Contributor

@TrevorBurnham I found the issue with the react-create-class dependency, it turns out we had to update the browserify config to point to the global before we build the UMD. This gets things working again for me locally.

@TrevorBurnham
Copy link
Contributor

TrevorBurnham commented Aug 7, 2017

This could function as a workaround for our internal build issue, but at the expense of inducing a deprecation warning in React 15.5 and breaking the project entirely in React 16. Surely there must be a way to define a react-create-class module that maps to React.createClass as part of our React < 15.5 build, rather than foregoing the module entirely?

@TrevorBurnham
Copy link
Contributor

@banderson react-select has significantly changed their build process since we last looked at this. Those changes will come in to react-select-plus once #96 is merged. Let's reassess after that's merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants