Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for require #32

Closed
iamajoe opened this issue Apr 15, 2015 · 2 comments
Closed

Support for require #32

iamajoe opened this issue Apr 15, 2015 · 2 comments

Comments

@iamajoe
Copy link

iamajoe commented Apr 15, 2015

Tooltip, Drop and Tether should have support for require. In my case, I don't really want those vars in the global window since it's a bad practice. I would prefer to use require and amd the three: Tooltip, Drop and Tether. From what I gather, Tether already does this.

I'll try and pull request this. The problem, from what I see, is Tether needing to access the window to get Tether or Drop. There should be some strategy like the Tether one to use whatever is available.

Correct me if I'm wrong.

@slorber
Copy link

slorber commented Apr 17, 2015

+1

@geekjuice
Copy link
Contributor

Thanks for using Tooltip. I recently pushed out some changes that should now help with this issue 😺 Drop and Tooltip now come without the Tether code prepended, so you can require each separately (as a module system should do). Feel free if you run into any issues though and I'll be more than happy to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants