Create a Assignee Picker that allows the user to add/remove/modify the assignee of an issue #1288 #1303

garbanzos · 2016-03-02T13:41:13Z

Works in the same way as milestone picker
Followed the implementation of milestone picker

damithc · 2016-03-03T11:43:50Z

Change status when ready for review. Also, post a screenshot. The interaction should be similar to label picker (i.e. type to select). The avatar can be shown bigger.

damithc · 2016-03-25T04:51:19Z

src/main/java/backend/Logic.java

+            return true;
+        }
+
+        //TODO yy change remove isUpdateSuccessful from log msg


Is this TODO supposed to be here?

Nope. I will remove it.

damithc · 2016-03-27T07:06:07Z

@ndt93 this issue needs a reviewer. @garbanzos please ask for a reviewer if you don't get one within 24 hours after it is ready for review.

ndt93 · 2016-03-27T07:13:34Z

@dariusf Can you help review this? Thanks.
@garbanzos Can you write tests for this?

dariusf · 2016-03-27T16:40:50Z

src/main/java/ui/components/pickers/AssigneePicker.java

+    private void showAssigneePicker(TurboIssue issue) {
+        List<TurboUser> assigneeList = ui.logic.getRepo(issue.getRepoId()).getUsers();
+        AssigneePickerDialog assigneePickerDialog = new AssigneePickerDialog(stage, issue, assigneeList);
+        Optional<AssigneePickerDialogResponse> assigneeDialogResponse = assigneePickerDialog.showAndWait();


Think I said the same things for the milestone picker:

Types are implementation details, so we can leave them out of variable names. assignees?

We don't really need to name the intermediate result, so we can do new AssigneePickerDialog(...).showAndWait(...).

Also, can the dialog response by an inner class? Then we don't have to prefix it.

- intial semi-working version of assignee picker - UI and interactions of assignee picker attempts to mimic the label picker

…gneePickerTests for assignee picker

- Scroll pane displays message when there are no assignees that match query - Added resetList & fixed problem that existing assignee is not showing - Change style of label and padding of flowpane

dariusf · 2016-04-04T05:34:29Z

src/main/java/ui/components/pickers/AssigneePickerDialog.java

+        return issue.getAssignee().get().equals(assignee.getLoginName());
+    }
+
+    private void setupButtons(DialogPane assigneePickerDialogPane) {


To make this a little less verbose, we can maybe leave out the assigneePicker prefix, since it's clear from the context in which this method appears.

dariusf · 2016-04-04T05:35:11Z

The avatar taking a long time to load could be made a separate issue.

garbanzos · 2016-04-04T06:31:03Z

@dariusf ready for review again.
I haven't changed the error handling part though.

damithc · 2016-04-04T07:59:34Z

src/main/java/ui/components/pickers/AssigneePickerState.java

+import java.util.stream.Stream;
+
+public class AssigneePickerState {
+    private List<PickerAssignee> currentAssigneesList;


I think the better name is ...UsersList or ...MembersList? There can be only one assignee but there can be a list of users. Create a separate issue to change Assignee to a more appropriate name (Member/User) across all this code.

…ith spaces - Assignee picker related backend methods accept Optional<String> as argument - Refactored isFaded to isMatching and removed isHighlighted in PickerAssignee - Added AssigneePickerDialogResponse - Added removeAssignee in TurboIssue - Tweaked UI of assignee picker

- Changed context menu text for assignee picker menu item - Removed test case of 'a' keyboard shortcut from chromedrivertest - Added GUI tests for assignee picker

- Moved getExistingAssignee and getSelectedAssignee to PickerAssignee - Moved AssigneePickerTests from unstable to guitests - AssigneePickerDialogResponse is now an inner class of AssigneePickerDialog

…ted classes

…e no longer used

garbanzos force-pushed the 1288-assignee-picker branch 2 times, most recently from b103133 to 45bb8c3 Compare March 3, 2016 11:37

damithc added aspect-ui priority.medium status.ongoing and removed aspect-ui priority.medium labels Mar 3, 2016

garbanzos force-pushed the 1288-assignee-picker branch 3 times, most recently from 06b2d22 to 548cd2a Compare March 20, 2016 16:46

garbanzos force-pushed the 1288-assignee-picker branch from 4e2177d to f05c2b6 Compare March 23, 2016 20:06

garbanzos added status.toReview status.ongoing and removed status.ongoing status.toReview labels Mar 23, 2016

garbanzos force-pushed the 1288-assignee-picker branch from 1a20f31 to 2e7e86d Compare March 24, 2016 14:52

garbanzos added status.toReview and removed status.ongoing labels Mar 24, 2016

damithc reviewed Mar 25, 2016
View reviewed changes

garbanzos force-pushed the 1288-assignee-picker branch from 313662d to 61a2c10 Compare March 25, 2016 09:34

dariusf reviewed Mar 27, 2016
View reviewed changes

garbanzos removed the status.ongoing label Apr 3, 2016

garbanzos added 8 commits April 4, 2016 12:15

Initial version of assignee picker

f0a6a14

- intial semi-working version of assignee picker - UI and interactions of assignee picker attempts to mimic the label picker

Added LogicTest and RepoIOTests for Assignee Picker

e113770

Increased avatar and label size

41b8904

Separated updates download and local model update for assignee picker

795de1b

Added ModelTests, RepoOpControlTest, AssigneePickerStateTest and Assi…

0db3982

…gneePickerTests for assignee picker

Added updateChangeAssigneeMenuItem to ListPanel

69a8f03

Changed the area that displays matching assignees to a scroll pane

6fd6f6d

- Scroll pane displays message when there are no assignees that match query - Added resetList & fixed problem that existing assignee is not showing - Change style of label and padding of flowpane

Implemented setAssignee in DummyRepoState

15cfdbc

garbanzos force-pushed the 1288-assignee-picker branch from c193684 to ac81456 Compare April 4, 2016 04:52

dariusf reviewed Apr 4, 2016
View reviewed changes

dariusf added status.toMerge and removed status.toReview labels Apr 4, 2016

damithc reviewed Apr 4, 2016
View reviewed changes

damithc added status.mergeApproved and removed status.toMerge labels Apr 4, 2016

garbanzos added 6 commits April 4, 2016 18:23

Pressing A now opens assignee picker

d508660

- Changed context menu text for assignee picker menu item - Removed test case of 'a' keyboard shortcut from chromedrivertest - Added GUI tests for assignee picker

Refactored assignee picker related classes

a548f5c

- Moved getExistingAssignee and getSelectedAssignee to PickerAssignee - Moved AssigneePickerTests from unstable to guitests - AssigneePickerDialogResponse is now an inner class of AssigneePickerDialog

Assignee Picker Dialog pops out before issue is loaded on browser now

34d8fa4

Refactored assignee to user where appropriate in assignee picker-rela…

970eba2

…ted classes

Context menu now shows Change Assignee menu item

e0792d2

garbanzos force-pushed the 1288-assignee-picker branch from 5ebd3ee to e0792d2 Compare April 4, 2016 10:33

Removed SendKeysToBrowserEvent related classes and methods as they ar…

a61dd08

…e no longer used

garbanzos merged commit a61dd08 into HubTurbo:master Apr 4, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create a Assignee Picker that allows the user to add/remove/modify the assignee of an issue #1288 #1303

Create a Assignee Picker that allows the user to add/remove/modify the assignee of an issue #1288 #1303

garbanzos commented Mar 2, 2016

damithc commented Mar 3, 2016

damithc Mar 25, 2016

garbanzos Mar 25, 2016

damithc commented Mar 27, 2016

ndt93 commented Mar 27, 2016

dariusf Mar 27, 2016

dariusf Apr 4, 2016

dariusf commented Apr 4, 2016

garbanzos commented Apr 4, 2016

damithc Apr 4, 2016

Create a Assignee Picker that allows the user to add/remove/modify the assignee of an issue #1288 #1303

Create a Assignee Picker that allows the user to add/remove/modify the assignee of an issue #1288 #1303

Conversation

garbanzos commented Mar 2, 2016

damithc commented Mar 3, 2016

damithc Mar 25, 2016

Choose a reason for hiding this comment

garbanzos Mar 25, 2016

Choose a reason for hiding this comment

damithc commented Mar 27, 2016

ndt93 commented Mar 27, 2016

dariusf Mar 27, 2016

Choose a reason for hiding this comment

dariusf Apr 4, 2016

Choose a reason for hiding this comment

dariusf commented Apr 4, 2016

garbanzos commented Apr 4, 2016

damithc Apr 4, 2016

Choose a reason for hiding this comment