Label picker: unmatched labels look like disabled #1333

[tsoonjin]

Fixes #1333

[damithc]

It's better. But as long as we use opacity, they are going to look 'disabled'. I think the solution is to make the label clickable when the mouse is over it. e.g. change mouse pointer and/or remove opacity

[tsoonjin]

I think we just need a better way of highlighting the matched label from the rest e.g making it pop-up using size. In hindsight, using border is not really a good choice. What do you think ?

[damithc]

yes, it's nice if we can emphasize matching labels without de-emphasizing unmatched labels. Not sure how hard it is to do so. I don't want to do anything (such as increasing size) that changes the positioning of labels as the user types. In spite of whatever we do there, the labels need to look clickable when hovered over.

[tsoonjin]

Ok. So as long as the position of the labels remain the same you are ok with it right ? Coupled that by changing the mouse pointer, I think it will be perfect already.

[damithc]

Yup. Let us know when the code is ready for review.

[tsoonjin]

Here is the updated version where the cursor icon will change when hover on a clickable label.

Ready for review @ndt93

[ndt93]

This style part can be extracted into another method.

[tsoonjin]

noted