BoardAutoCreator should not prompt for save if there is no need to #1461
#1462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xinan Hey xinan, can you resolve the conflicts with mater branch? |
xinan
changed the title
BoardAutoCreator should not prompt for save if there is no need toBoardAutoCreator should not prompt for save if there is no need to #1461
xinan
force-pushed
the
1461-fix-boardautocreator
branch
from
7fbc3f0
to
538394e
Compare
| if (isSaveBoardDialogResponsePositive(boardName)) ui.getMenuControl().saveBoardAs(); | ||
| private void saveBoardAfterUserConfirmationIfNeeded(String boardName) { | ||
| boolean isNeeded = !prefs.getLastOpenBoardPanelInfos().isPresent() | ||
| || !prefs.getLastOpenBoardPanelInfos().get().equals(panelControl.getCurrentPanelInfos()); |
There was a problem hiding this comment.
I think a more accurate name is isOpenBoardDifferentFromSavedBoard or something like that, because that's what the condition seems to be checking.
| @@ -1,5 +1,7 @@ | |||
| package prefs; | |||
|
|
|||
| import java.util.Objects; | |||
|
|
|||
| public class PanelInfo { | |||
There was a problem hiding this comment.
Not a change in this PR, but can you help adding the header comment for this class?
| @@ -126,11 +132,20 @@ private boolean isNewBoardCreationDialogConfirmed() { | |||
| response.get().getButtonData() == ButtonData.OK_DONE; | |||
| } | |||
|
|
|||
| /** | |||
| * Called upon the Boards > Save being clicked | |||
| */ | |||
| import java.util.Objects; | ||
|
|
||
| /** | ||
| * Represents the information about a Panel. Contains two String attributes {@code name} and {@code filter}. |
There was a problem hiding this comment.
2nd sentence is unnecessary and easily outdated.
|
Can merge after removing the comment text mentioned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1461
Now it will only prompt for save if current board is dirty, or current board has not been saved before.
If current board is a dirty saved board, it will trigger
Save.If current board has not been saved before, it will trigger
Save as.