assignee & milestone picker: position needs adjusting #1478 #1482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@m133225 Could you help review this? |
garbanzos
force-pushed
the
1478-assignee-and-milestone-picker-position
branch
from
9ed5755
to
1bd13b0
Compare
| @@ -64,6 +65,11 @@ private void fillInputFieldWithMilestoneName(String milestoneName) { | |||
| inputField.setText(milestoneName); | |||
| } | |||
|
|
|||
| private final void positionDialog(Stage stage) { | |||
There was a problem hiding this comment.
This (together with other similar functionalities) seems to be extractable into a separate class that the pickers extend from. But I guess this should do for now.
garbanzos
force-pushed
the
1478-assignee-and-milestone-picker-position
branch
from
1bd13b0
to
5bb20b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1478.