repo picker: move 'add repo' functionality to a menu item or a separate button. #1468 #1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raisfathin
force-pushed
the
1468-move-add-repo-functionality
branch
2 times, most recently
from
b6edf3a
to
91cb8db
Compare
raisfathin
force-pushed
the
1468-move-add-repo-functionality
branch
3 times, most recently
from
567e3d4
to
c1a4053
Compare
|
Ready for review! |
raisfathin
force-pushed
the
1468-move-add-repo-functionality
branch
2 times, most recently
from
88a6d26
to
f223605
Compare
|
Can post a screenshot? |
|
Dialog asking for new repository: When the user enters an invalid GitHub repo: |
| Optional<String> chosenRepo = dialog.showAndWait(); | ||
| if (chosenRepo.isPresent() && !defaultRepo.equals(chosenRepo.get())) { | ||
| onValueChangeCallback.accept(chosenRepo.get()); | ||
| if (repoId != null && !defaultRepo.equals(repoId)) { |
There was a problem hiding this comment.
Just realised the repo picker isn't a Dialog subclass, and so doesn't have access to showAndWait.
Instead of using null, could we pass an optional instead? That's a bit of an abuse of optionals (their use case is as return values, not parameters), but since we're not using showAndWait I guess it's fine.
There was a problem hiding this comment.
It was, but apparently I couldn't get it to spawn another dialog (the addRepository dialog one). So I had to make it not subclassing Dialog. Is it okay?
raisfathin
force-pushed
the
1468-move-add-repo-functionality
branch
from
f223605
to
e541c37
Compare
|
Done. Ready for another review! |
raisfathin
force-pushed
the
1468-move-add-repo-functionality
branch
from
e541c37
to
4e83a48
Compare
raisfathin
force-pushed
the
1468-move-add-repo-functionality
branch
from
4e83a48
to
aefbc5c
Compare
raisfathin
force-pushed
the
1468-move-add-repo-functionality
branch
from
aefbc5c
to
be8da2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.