Milestone Picker: previous and new milestone should not be the same #1487 #1488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m133225
force-pushed
the
1487-different-suggested-milestone
branch
4 times, most recently
from
0433851
to
2c8a0fc
Compare
|
Ready for review. |
| @@ -273,6 +275,12 @@ private void addMatchingMilestones(List<PickerMilestone> milestonesToBePopulated | |||
| .findFirst(); | |||
| } | |||
|
|
|||
| private List<PickerMilestone> getSelectableMilestones(List<PickerMilestone> milestones) { | |||
There was a problem hiding this comment.
Will need a header comment here. What is Selectable and how is it defined? I didn't understand right away why is it selectable by reading the method body.
If it is difficult to write a header comment that is not tied to implementation, maybe renaming the method works better.
m133225
force-pushed
the
1487-different-suggested-milestone
branch
from
2c8a0fc
to
382aa81
Compare
|
@HansNewbie Made the changes. |
| } | ||
|
|
||
| /** | ||
| * Fills the input field of milestone picker dialog with default milestone's title | ||
| * Fills the input field of milestone picker dialog with best suggested milestone's name |
There was a problem hiding this comment.
Either use sugested or best matching. best suggested sounds weird.
m133225
force-pushed
the
1487-different-suggested-milestone
branch
2 times, most recently
from
32aaeda
to
3814c8c
Compare
… assigned milestone. MilestonePickerDialog will simply fill its textfield with the best suggested milestone name.
…r getSelectableMilestones.
…ded test and updated comments.
m133225
force-pushed
the
1487-different-suggested-milestone
branch
from
3814c8c
to
de7055a
Compare
|
@HansNewbie Made the changes and added a test. |
|
Looks good. Travis failed was not related to this PR, restarted it. |
|
@m133225 Can merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1487