Add ability to mark issues as read #640 #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need two fields to track read status: we can't just clear the marked-as-read status upon an issue being updated because we want to indicate which of its events are new.
The problem is that we set the the read status of issues in MultiModel::add instead of MultiModel::addPending. The first happens on every change to the model, including updates, whereas the second happens only when a new model is added. The fix is to move it to addPending: that's the only time we should reset the read status of an issue to what is in Preferences.
Bugs: - On refreshing a panel with an updated filter, all the events and comments would disappear before being loaded again - After marking an issue as read, markedReadAt was cleared The cause was that all transient state (metadata, read status) was not being transferred when issues were updated. This was due to TurboIssues being constructed from new external Issue objects that were created as part of the update process. The fix is to explicitly ensure that transient state is transferred.
This is if they occurred before an issue was marked as read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#640