Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for skinned mesh bug on galaxy s6 devices #48

Merged
merged 3 commits into from
Jan 8, 2018
Merged

Workaround for skinned mesh bug on galaxy s6 devices #48

merged 3 commits into from
Jan 8, 2018

Conversation

brianpeiris
Copy link
Contributor

Fixes #32

@johnshaughnessy
Copy link
Contributor

Nice find!

robertlong
robertlong approved these changes Jan 8, 2018
View reviewed changes
Copy link
Contributor

@robertlong robertlong left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @brianpeiris!

@brianpeiris brianpeiris merged commit dc10dbe into master Jan 8, 2018
@brianpeiris brianpeiris deleted the bug/galaxy-s6-skinned-meshes branch January 8, 2018 19:38
markusTraber added a commit to farvel-space/space-client that referenced this pull request Jun 22, 2022
@markusTraber
Pull request Hubs-Foundation#48: Feature/FARM-449 integrate connectiv…
aef9a7e 
…ity diagnostics

Merge in FAR/space-client from feature/FARM-449-integrate-connectivity-diagnostics to main

* commit '707f3d0c6604c4e0d853202bd74eeb936136baa3':
  FARM-449: Added default parameter value
  FARM-449: Updated the test and added browser user agent.
  Fixed missing client_id (didn't actually influence the test result) Added try-catch based on user testing
  Example usage of the ConnectionTest component. Not in the right place necessarily, but good enough to test.
  Minor change to code and label
  Tidied up stray debug code
  Added test for opening microphone
  Make redirect optional when opening new Hubs rooms (used by ConnectionTest component)
  Initial connection debugging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertlong robertlong robertlong approved these changes

@johnshaughnessy johnshaughnessy Awaiting requested review from johnshaughnessy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brianpeiris @johnshaughnessy @robertlong