Force AppLogo refresh when system theme changes #5585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding you @brianpeiris as you were the last one updating that code. |
brianpeiris
suggested changes
Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
AppLogocomponent is not re-rendered when a system theme update happens. It only re-rendered when closing the preferences in the hub as that conditionally renders UI. This means that in any situations where the logo is visible and the system theme is updated we don't update the logo. As far as I know this only happens in the home screen.This PR forces a
AppLogore-render when the system theme is updated by using the already existinguseDarkModehook. It also removes theget-app-logoutil as it's only been used for the logo update but we get the same information from the hook.