Add third person camera view #5633
Conversation
src/components/player-info.js
Outdated
| const mesh = createModelForSkinnedMesh(o); | ||
| if (mesh) { | ||
| isSkinnedAvatar = true; | ||
| o.parent.add(headlessMesh); | ||
| o.parent.add(mesh); |
There was a problem hiding this comment.
We(me and @jeus0630) need help this lines.
Default status is not shown head of avatar.
But, we don't know how to toggle avatar head.
So, we change here to avatar head always shows.
If someone helps 'how to toggle avatar head' we can fix here.
There was a problem hiding this comment.
I think you can do that with the camera layers. Have a look at: https://github.com/mozilla/hubs/blob/cb20d48f4acc7e810928a9b7b302bdab51589c65/src/systems/camera-system.js#L281-L282
I will probably implement that myself this way. Will tell you here if I have sth. to show.
src/react-components/ui-root.js
Outdated
| @@ -1561,6 +1562,23 @@ class UIRoot extends Component { | |||
| </> | |||
| )} | |||
| <ChatToolbarButtonContainer onClick={() => this.toggleSidebar("chat")} /> | |||
| {entered && ( | |||
| <ToolbarButton | |||
| icon={<VRIcon />} | |||
There was a problem hiding this comment.
We(me and @jeus0630. my team.) are not have any icon of '3rd person view' T.T
Help
There was a problem hiding this comment.
How about making an option in the preferences to toggle between 1st and 3rd person?
|
@jeus0630 @juunini As I told, I did my own implementation which works with the layers. Here you can see the comparison to the Mozilla Master. Here is the branch itself. I implemented an option to switch between 1st and 3rd person via the preferences. All the interesting stuff for you is in camera-system.js. I am not sure about how I implemented it. The function "setMode" basically ignores calls to switch to 3rd person if the user is connected via VR. |
|
@markusTraber Thanks :) |
|
@juunini |
|
@piyush2greedy You can check out here #5660 |
|
@jeus0630 How to enable this feature? I see that it had been merged to |
Doing
Notes