Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace CircleCI configuration with GitHub workflow #5649

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

brianpeiris
Copy link
Contributor

  • Adds a test-and-deploy-storybook workflow that runs npm test (which mostly does linting) on the client and the admin panel.
  • The workflow also builds and deploys the component storybook to gh-pages, but only for pushes to the master branch (https://mozilla.github.io/hubs)
  • Changed some eslint rules to warnings in the admin panel config, similar to the changes we made in Upgrade to Node LTS (16) and Webpack 5 #5619
  • Removed the npm run build step from npm test, since that is already covered by the existing build workflow
  • Fixed the ava configuration to conform to the updated version we now use.

Copy link
Contributor

@bryanenders bryanenders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fancy

- run: npm test

- run: cd admin && npm ci
- run: cd admin && npm test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed the npm run build step from npm test, since that is already covered by the existing build workflow

Good catch! 👏

@brianpeiris brianpeiris merged commit 00dc537 into master Aug 17, 2022
@brianpeiris brianpeiris deleted the circleci-to-github-workflow branch August 17, 2022 14:29
@brianpeiris
Copy link
Contributor Author

Had to add one extra commit to this, since the changes in #5651 broke Storybook. 7955a44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants