Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add required reference to NAF in scene.js #5696

Merged
merged 1 commit into from
Sep 2, 2022
Merged

Add required reference to NAF in scene.js #5696

merged 1 commit into from
Sep 2, 2022

Conversation

keianhzo
Copy link
Contributor

@keianhzo keianhzo commented Sep 2, 2022

No description provided.

brianpeiris
brianpeiris approved these changes Sep 2, 2022
View reviewed changes
Copy link
Contributor

@brianpeiris brianpeiris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we would work towards removing reliance on these globals, and import them explicitly instead, but this looks good as an immediate fix.

@keianhzo keianhzo merged commit 340f14f into master Sep 2, 2022
@keianhzo keianhzo deleted the fix-scene-js branch September 2, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianpeiris brianpeiris brianpeiris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@keianhzo @brianpeiris