Add Admin Panel UI for account deletion #5716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanenders
force-pushed
the
feature/account-deletion
branch
from
5e1a5bb
to
69b7bc7
Compare
|
Rebased |
nickgrato
reviewed
Nov 18, 2022
nickgrato
reviewed
Nov 18, 2022
nickgrato
reviewed
Nov 18, 2022
nickgrato
reviewed
Nov 18, 2022
nickgrato
reviewed
Nov 18, 2022
| </Button> | ||
| )} | ||
|
|
||
| {deleteState === deleteStates.confirming && ( |
There was a problem hiding this comment.
might be nice to add a new function like this
/**
* compare state
* @return boolean
*/
const isDeleteState = useCallback(
state => {
return state === deleteState;
},
[deleteState]
);
and then refactor ones like this to..
{isDeleteState(Confirming) && (
nickgrato
reviewed
Nov 18, 2022
nickgrato
reviewed
Nov 18, 2022
nickgrato
approved these changes
Nov 18, 2022
bryanenders
force-pushed
the
feature/account-deletion
branch
from
82b5c12
to
fa7b8f9
Compare
|
Squashed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a delete button to the account edit screen in the admin panel. Includes a confirmation dialog and states. Also removes the bulk delete capability from the account list.
Goes with Hubs-Foundation/reticulum#628