Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avatar page fails to load because a roundabout dependency chain1 ends up loading netcode.js, which expects NAF to exist. Untangling that is a bit difficult, but also we don't want to be using NAF in the new netcode anyway, so for now just add a check to prevent the page from failing to load.
The real fix is to continue removing use of globals like APP and NAF and to figure out a better solution for system initialization than directly executing code in the module.
Footnotes
avatar.js loads app.ts to define the
APP
global, since various things rely on it. app.ts needsmainTick
from hubs-systems.ts which in turns ends up also loading all the systems code, including netcode.ts which immediately executes some code relying onNAF
global. ↩