Hide LOD progressive loading mode behind the flag #5795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently LOD progressive loading mode is chosen by default but it may be useless without rangerequests that is hidden by flag because without rangerequests the glTF loader starts with loading entire file and just lazily parse higher levels on demand. Just lazy parsing isn't worth. It just makes the loading path complex. So better to hide LOD progressive loading mode behind the flag. Enable both range requests and LOD progressive loading mode if rangerequests query strings is in URL.
takahirox
commented
Nov 15, 2022
| @@ -134,7 +134,7 @@ | |||
| "semver": "^7.3.2", | |||
| "three": "github:mozillareality/three.js#56e7c46d991cc16bff82bdbb03c7bfba4620567f", | |||
| "three-ammo": "github:mozillareality/three-ammo", | |||
| "three-gltf-extensions": "^0.0.13", | |||
| "three-gltf-extensions": "^0.0.14", | |||
There was a problem hiding this comment.
For reviewers: Found a bug in "all" loading mode so needed to fix and upgrade.
johnshaughnessy
approved these changes
Nov 28, 2022
|
It looks like the test-and-deploy-storybook job failed with a network error: I'm going to rerun it to see if it was just a blip. [Update: The rerun succeeded.] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the internal discussion with @netpro2k and @johnshaughnessy
Currently LOD progressive loading mode is chosen by default but it may be useless without rangerequests that is hidden by flag because without rangerequests the glTF loader starts with loading entire file and just lazily parse higher levels on demand.
Just lazy parsing isn't worth. It just makes the loading path complex.
So better to hide LOD progressive loading mode behind the flag. Enable both range requests and LOD progressive loading mode if rangerequests query strings is in URL.