Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle some networking edge-cases #5813

Merged
merged 1 commit into from
Nov 25, 2022
Merged

Handle some networking edge-cases #5813

merged 1 commit into from
Nov 25, 2022

Conversation

johnshaughnessy
Copy link
Contributor

  • When owners leave, take ownership with a timestamp from the most recently received (valid) update message about that entity.
  • When replaying stored updates, rewrite ownership if the message came from a client that has already left, as if we had taken ownership at at that time.
  • Always send full-sync messages when ownership changes, so that rejectable in-flight updates don't break eventual consistency guarantees.
  • Do not send or receive messages until we are assigned a client ID (which happens after the phoenix channel connects.)
  • (Minor) Schedule network ticks to more consistently send at the configured frequency.

Builds on #5811

@johnshaughnessy johnshaughnessy mentioned this pull request Nov 24, 2022
Merged
@johnshaughnessy @netpro2k
Handle some networking edge-cases
b9fb00b 
- When owners leave, take ownership with a timestamp from the most
recently received (valid) update message about that entity.
- When replaying stored updates, rewrite ownership if the message came
from a client that has already left, as if we had taken ownership at
at that time.
- Always send full-sync messages when ownership changes, so that
rejectable in-flight updates don't break eventual consistency guarantees.
- Do not send or receive messages until we are assigned a client
ID (which happens after the phoenix channel connects.)
- (Minor) Schedule network ticks to more consistently send at the
configured frequency.

Co-authored-by: Dominick D'Aniello <netpro2k@gmail.com>
Base automatically changed from subscribe-early-to-nn to master November 25, 2022 18:08
@johnshaughnessy johnshaughnessy merged commit 5ec5f98 into master Nov 25, 2022
@johnshaughnessy johnshaughnessy deleted the feature/networking-edge-cases branch November 25, 2022 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@johnshaughnessy