Re-enable eslint rules, reformat files with prettier. #5817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` src/react-components/banner/Banner.js 65:20 warning React Hook useCallback does nothing when called with only one argument. Did you forget to pass an array of dependencies? react-hooks/exhaustive-deps 106:21 warning React Hook useCallback does nothing when called with only one argument. Did you forget to pass an array of dependencies? react-hooks/exhaustive-deps 130:24 warning 'status' is missing in props validation react/prop-types ```
johnshaughnessy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR re-enables eslint rules (or removes them from our eslint config to restore them to their defaults, and formats files according to prettier rules.
We relaxed eslint rules when we upgraded to webpack 5. More context can be found in that PR summary.
Several inline configs (
eslint-disableandeslint-disable-next-line) were added to silence warnings/errors, which we prefer to disabling those rules across the whole project. Reports that ignore inline configs can still be generated with the--no-inline-configflag, for example:Prettier rules were re-enabled and many files were reformatted with
npm run prettier. We should expect to have to resolve some formatting-related merge conflicts with outstanding branches. Unfortunately, we don't see a way around this if we want to conform to the prettier rule.