Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Storybook #5844

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Fix Storybook #5844

merged 1 commit into from
Dec 6, 2022

Conversation

keianhzo
Copy link
Contributor

@keianhzo keianhzo commented Dec 5, 2022

We have recently refactored some code to start using a store instance and now the theme.js file that indirectly imports aframe/three through store->effects. This breaks Storybook.

I've moved the effects modes to the contants file so we can import independently.

Reference: 82e8bc7

@keianhzo keianhzo merged commit f81f203 into master Dec 6, 2022
@keianhzo keianhzo deleted the fix-storybook branch December 6, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants