Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tooltip location to not block the canvas in mobile #5868

Merged
merged 2 commits into from
Dec 22, 2022

Conversation

keianhzo
Copy link
Contributor

Fixes #5859

The Notification container was blocking the canvas in mobile mode. If updated to to be at the top in mobile and bottom in Desktop and only take the required space.

Copy link
Contributor

@takahirox takahirox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on it. I confirmed that the unclickable problem has been resolved with this change both on mobile and desktop.

But the tooltip looks being placed a bit too top on mobile portrait mode. Is this instentional?

image

@keianhzo
Copy link
Contributor Author

Thanks for testing that @takahirox there were a few possible mobile/viewport size combinations that I missed to test. sI've updated to account for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Camera control not functioning on mobile with virtual joysticks enabled
2 participants