Add LightTag and call Three.js light.dispose when removed #5915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add LightTag component that must be set for all lights. Call Three.js light.dispose() when removed in remove-object3D-system. This new tag and flow provides a proper light resource disposing. Currently light.dispose() is called right after DirectionalLight creation in inflator/directional-light if light.shadow.map is non-null but it seems a bug because light.shadow.map should be null when light is created. This commit also fixes it by removing the lines. Light will be properly disposed when removed with the change.
| if (light.shadow.map) { | ||
| light.shadow.map.dispose(); | ||
| (light.shadow.map as any) = null; // TODO: Correct the Typescript definition in three. This /is/ nullable. | ||
| } |
There was a problem hiding this comment.
Oops! Thanks for removing this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
LightTagcomponent that must be set for all lights. Call Three.jslight.dispose()when removed inremove-object3D-system.This new tag and flow provides a proper light resource disposing.
Currently
light.dispose()is called right afterDirectionalLightcreation ininflator/directional-lightiflight.shadow.mapis non-null but it seems a bug becauselight.shadow.mapshould be null when light is created. This commit also fixes it by removing the lines. Lights will be properly disposed when removed with the change.