Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

newLoader anoyances #5921

Merged
merged 4 commits into from
Jan 31, 2023
Merged

newLoader anoyances #5921

merged 4 commits into from
Jan 31, 2023

Conversation

netpro2k
Copy link
Contributor

Fixes a few misc annoyances when using newLoader:

  • Images were always set to opaque. This restores a slightly less aggressive version of what we had before. gifs will be set to "clip", jpegs will be set to "opaque", and everything else will be "blend".
  • debugLocalScene did not work with newLoader
  • Codepaths other than ctrl+v or drag+drop file did not use new loader. This PR captures most of the rest of the path's by implementing newLoader in spawnObjectInFrontOfPlayer which is used by chat spawning, the place menu, uploads, etc.

@johnshaughnessy johnshaughnessy merged commit 267e53b into master Jan 31, 2023
@johnshaughnessy johnshaughnessy deleted the newloader-anoyances branch January 31, 2023 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnshaughnessy johnshaughnessy johnshaughnessy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@netpro2k @johnshaughnessy