Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add button to remove bit-ecs entities #5927

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Conversation

keianhzo
Copy link
Contributor

@keianhzo keianhzo commented Feb 1, 2023

I find the ecsDebug panel pretty useful while debugging components, I just missed a way to easily remove a bit-ecs entity to test exit cases. This PRs adds such a button to the object properties panel.

Copy link
Contributor

@netpro2k netpro2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a useful debug tool. Note that the user-facing way to delete a spawned entity (something you paste in or upload) is hovering over it and pushing the X key. Obviously we need to make that more discoverable (probably y implementing the handler for the button in the object menu)

@johnshaughnessy
Copy link
Contributor

RE "Implement the handler for the button in the object menu"

I've done this in another commit (unfortunately part of an unrelated PR): 02b9a4d

@keianhzo
Copy link
Contributor Author

keianhzo commented Feb 7, 2023

I wasn't aware of that shortcut in the new loader. It seems to work for spawned nodes from the media toolbar but not from the chat. For testing the new bit-ecs components I was using mostly the chat command that's why this remove button.

@keianhzo keianhzo merged commit c8bd5da into master Feb 7, 2023
@keianhzo keianhzo deleted the bit-ecs-debug-remove-entity branch February 7, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants