Add SpotLight to bitecs #5931
Merged
Add SpotLight to bitecs #5931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnshaughnessy
approved these changes
Feb 7, 2023
netpro2k
reviewed
Feb 15, 2023
src/inflators/spot-light.ts
Outdated
| shadowRadius: number; | ||
| }; | ||
|
|
||
| const DEFAULTS = { |
There was a problem hiding this comment.
Not sure if I like it better but I notice we have to duplicate a lot of information with these defaults...
We could use typeof: example
src/inflators/spot-light.ts
Outdated
| innerConeAngle: number; | ||
| outerConeAngle: number; | ||
| castShadow: boolean; | ||
| shadowMapResolution: [number, number]; |
There was a problem hiding this comment.
Not particularly important, but you can name the elements of a "tuple". Gives you slightly nicer type hinting:
shadowMapResolution: [width: number, height: number];| shadowRadius: 1.0 | ||
| }; | ||
|
|
||
| export function inflateSpotLight(world: HubsWorld, eid: number, params: SpotLightParams) { |
There was a problem hiding this comment.
This was discussed in anotehr PR, so whatever we decide there should apply here too... Since we provide default values the properties passed to the inflator (and exposed to JSX) should be optional, but then the type after applying defaults should have all fields be required. We can do that with typescript Partial/Required utility types.
takahirox
force-pushed
the
BitECSSpotLight
branch
from
7ff6301
to
d8cae2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
SpotLightto bitecs, similar to #5918.We may want to deprecate light components at some point and encourage to use glTF lights extension, but we don't need to drop the support right now.