Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HLS video play support to bitecs #5966

Merged
merged 2 commits into from
Mar 15, 2023
Merged

Add HLS video play support to bitecs #5966

merged 2 commits into from
Mar 15, 2023

Conversation

takahirox
Copy link
Contributor

This PR adds HLS video play support to bitecs.

The main changes are

  • Make createHLSPlayer() util function
  • Add HLSVideoTexture which holds HLS video player and cleans up it when the texture is disposed
  • loadVideoTexture() creates HLSVideoTexture if video is HLS

Copy link
Contributor

@netpro2k netpro2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments as DASH PR, I don't think we need the setter, and this is probably a good time to bump hlsjs since we need to do testing anyway.

* Make createHLSPlayer() util function
* Add HLSVideoTexture which holds HLS video player and
  cleans up it when the texture is disposed
* loadVideoTexture() creates HLSVideoTexture if video is HLS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants