Take soft ownership for video with bitecs #5969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnshaughnessy
approved these changes
Feb 28, 2023
src/bit-systems/video-system.ts
Outdated
| @@ -100,7 +101,8 @@ function audioEmitterSystem(world: HubsWorld, audioSystem: AudioSystem) { | |||
| } | |||
|
|
|||
| const OUT_OF_SYNC_SEC = 5; | |||
| const networkedVideoQuery = defineQuery([NetworkedVideo]); | |||
| const networkedVideoQuery = defineQuery([Networked, NetworkedVideo]); | |||
| const networkedVideoEntryQuery = enterQuery(networkedVideoQuery); | |||
There was a problem hiding this comment.
Suggestion: Rename ...EntryQuery -> ...EnterQuery
netpro2k
reviewed
Mar 7, 2023
Currently Hubs Client doesn't try to take soft ownwership for videos with bitecs so even if you upload a video you don't take ownership and the video doesn't play correctly. With this commit the client tries to take soft ownership and the problem will be resolved.
takahirox
force-pushed
the
VideoOwnership
branch
from
85aa040
to
f8ef3b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Hubs Client doesn't try to take soft ownwership for videos with bitecs so even if you upload a video you don't take ownership and the video doesn't play correctly.
With this commit the client tries to take soft ownership and the problem will be resolved.