-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changing image sizes #5984
changing image sizes #5984
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we still support non-square images for logos, if that's the case setting fixed widths will break proportional scaling.
|
||
img { | ||
height: 83px; | ||
width: 83px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think setting the width here will make non-square images to look stretched.
@@ -18,6 +18,11 @@ | |||
margin-bottom: 32px; | |||
} | |||
|
|||
:local(.logo) { | |||
height: 250px; | |||
width: 250px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same with this
@keianhzo the direction I'm getting from the desing and UX is to only support square. There is a ticket for me to update the copy for the logo inputs to say this . but i passed this note on to them! UPDATE - we will just have width cap |
updating logo size in nav and modal.