Implement Clone and Open link button function with bitecs #5985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the implementation of Object menu Clone and Open link button functions with bitecs.
takahirox
force-pushed
the
BitECSCloneButton
branch
from
06e2f5c
to
f8fd930
Compare
takahirox
changed the title
johnshaughnessy
approved these changes
Mar 9, 2023
| // TODO: Currently only accounts for the simple case of an external url | ||
| // but should support other type actions(eg: avatar update for avatar | ||
| // url, room switch for Hubs room url). | ||
| // See src/components/open-media-button.js |
There was a problem hiding this comment.
Now that we aren't duplicated the object menus for every object, we could have each of these actions called from their own buttons if we wanted to, and then show/hide the buttons as needed. Otherwise, we'll need to set the text of the button for "use avatar" / "use scene" / "visit room" / "open link". It doesn't seem that important which way we choose, but since the only thing the buttons will have in common will be their position (not their text or functionality when clicked), I thought it might make sense to make them different buttons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the implementation of object menu Clone and Open link button functions with bitecs.