Reorder sidebar "people" list with "you" at the top. #6031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikk15
requested review from
keianhzo,
johnshaughnessy,
takahirox and
nickgrato
nickgrato
reviewed
Apr 14, 2023
| @@ -101,7 +149,8 @@ export function PeopleSidebar({ | |||
| voiceChatEnabled, | |||
| isMod | |||
| }) { | |||
| const intl = useIntl(); | |||
| const user = people.find(person => !!person.isMe); | |||
There was a problem hiding this comment.
I think this all could work fine, another take that might make the jsx less confusing is to alter the people array, something like this.
const me = people.find(person => !!person.isMe);
filteredPeople = people.filter(person => !person.isMe);
filteredPeople.unshift(me);
and then you can just loop through filteredPeople
nickgrato
approved these changes
Apr 17, 2023
|
@nikk15 I was thinking about this feature as I hopped into the demo room today! It is super helpful! I was also going to suggest ordering "In Room" users above "In Lobby" users. Often as an event moderator, I find myself wanting to identify these users first, since they typically are the ones I need to kick or mute. I think, right now, they are mixed in with "In Lobby" users |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, "you" could be anywhere in a long list of guests. This fix moves "you" to the top so its easily visible.
NOTE: Typescript transition to come in a separate PR, as it affected multiple other components.