Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place the slider based on the media aspect ratio #6069

Merged
merged 1 commit into from
May 12, 2023

Conversation

keianhzo
Copy link
Contributor

We were placing the slider based on a 16:9 aspect ratio and that made the slider un-interactable for same ratios

Copy link
Contributor

@nikk15 nikk15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@keianhzo keianhzo merged commit 6b314a7 into master May 12, 2023
10 of 12 checks passed
@keianhzo keianhzo deleted the video-slider-position-fix branch May 12, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants