Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decouple branding sections from external details #6080

Merged
merged 1 commit into from
May 17, 2023
Merged

Decouple branding sections from external details #6080

merged 1 commit into from
May 17, 2023

Conversation

bryanenders
Copy link
Contributor

@bryanenders bryanenders commented May 16, 2023 •
edited
Loading

Why

Admin is an instance service. We don’t want it coupled to orchestration details or the Hubs managed service plans.

What

  • Hide branding sections based on DISABLE_BRANDING rather than ITA_SERVER and TIER

@nickgrato nickgrato requested a review from nikk15 May 16, 2023 19:52
nickgrato
nickgrato approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@nickgrato nickgrato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me - I'm a little behind on what's going on here but the syntax is correct and I get your general direction with the project.

nikk15
nikk15 approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@nikk15 nikk15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Config boolean values are always strings, right? If so, approved :)

@bryanenders bryanenders temporarily deployed to hc-bio May 17, 2023 14:16 — with GitHub Actions Inactive
@bryanenders bryanenders temporarily deployed to smoke May 17, 2023 14:16 — with GitHub Actions Inactive
@bryanenders
Decouple branding sections from external details
8a010d6 
Why
---
Admin is an instance service.  We don’t want it coupled to orchestration
details or the Hubs managed service plans.

What
----
* Hide branding sections based on `DISABLE_BRANDING` rather than
  `ITA_SERVER` and `TIER`
@bryanenders bryanenders temporarily deployed to smoke May 17, 2023 15:48 — with GitHub Actions Inactive
@bryanenders bryanenders temporarily deployed to hc-bio May 17, 2023 15:48 — with GitHub Actions Inactive
@bryanenders bryanenders merged commit 5fcc8ca into master May 17, 2023
14 checks passed
@bryanenders bryanenders deleted the disable-branding branch May 17, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickgrato nickgrato nickgrato approved these changes

@nikk15 nikk15 nikk15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bryanenders @nickgrato @nikk15