Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't play audio after the loading screen has been hidden #6091

Merged
merged 2 commits into from
Jun 1, 2023

Conversation

keianhzo
Copy link
Contributor

Don't play audio until the loading screen has disappeared.

@Exairnous
Copy link
Contributor

Does this include voice audio or just media? Scenes often take a long time to load for me and I really appreciate being able to hear conversations while loading.

@keianhzo
Copy link
Contributor Author

Good call @Exairnous I wasn't sure about that but I think it makes sense specially for slow connections.

@keianhzo keianhzo merged commit 2f27a02 into master Jun 1, 2023
10 of 12 checks passed
@keianhzo keianhzo deleted the audio-after-loaded branch June 1, 2023 10:25
@Exairnous
Copy link
Contributor

Thanks! I know this has just been merged, but now that I think about it, I'm not too sure what issue this PR solves, is it so that loud media elements that autoplay aren't annoying/distracting during room load? This seems like it's just auto-setting the audio preference and that got me to thinking that it would be really nice to have the bottom bar (as configured for the lobby with the invite, chat, and "more" buttons) during the scene load so you could just set preferences like that. This would have the added bonus (I think?) of allowing you to send chat messages during room load (which would be really great during an event if you were unable to load the room for some reason so you could tell the event host, similar to how you could with the Discord bot) and change room settings if you're a moderator. Having access to the people menu might be beneficial for moderation too, although that button overlays the scene so it might be harder to expose, hmm 🤔

Anyway, not trying to imply I'm against it, these are just a couple things this PR got me thinking about.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants