Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary div around logo #6106

Merged
merged 2 commits into from
May 30, 2023
Merged

Remove unnecessary div around logo #6106

merged 2 commits into from
May 30, 2023

Conversation

nikk15
Copy link
Contributor

@nikk15 nikk15 commented May 30, 2023 •
edited
Loading

  • the div wrapping the entry room modal was causing an issue with the logo displaying in the room entry modal. Removing it fixes this. We shouldn't need to wrap components in unnecessary divs if we are able to pass a classname prop for styling.
Screenshot 2023-05-30 at 11 56 12 AM

@nikk15 nikk15 temporarily deployed to smoke May 30, 2023 15:59 — with GitHub Actions Inactive
@nikk15 nikk15 temporarily deployed to hc-bio May 30, 2023 15:59 — with GitHub Actions Inactive
mikemorran
mikemorran reviewed May 30, 2023
View reviewed changes
Copy link
Contributor

@mikemorran mikemorran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

@nikk15 nikk15 merged commit 4402a83 into master May 30, 2023
12 checks passed
@nikk15 nikk15 deleted the set-logo-width-on-entry branch May 30, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikemorran mikemorran mikemorran left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nikk15 @mikemorran