Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make link entity grabbable #6107

Merged
merged 2 commits into from
Jun 1, 2023
Merged

Make link entity grabbable #6107

merged 2 commits into from
Jun 1, 2023

Conversation

keianhzo
Copy link
Contributor

Make the link entity grabbable and unhide the link menu.

Copy link
Contributor

@stalgiag stalgiag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and works well! Only note is that we might want to remove the non-working attempt to enable interactivity in the link inflator since interaction is set up here now. Might even be nice to have this be a prefab so this combination of components is consistent but that isn't a necessity.

@keianhzo
Copy link
Contributor Author

keianhzo commented Jun 1, 2023

Good catch! I've removed those.

@keianhzo keianhzo merged commit 6a51665 into master Jun 1, 2023
10 of 12 checks passed
@keianhzo keianhzo deleted the link-menu-fix branch June 1, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants