Upgrade client to React 18 (and upgrade dependencies). #6114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e73d3bf.
nikk15
commented
Jun 5, 2023
nikk15
commented
Jun 5, 2023
src/avatar.html
Outdated
| </script> | ||
| </head> | ||
|
|
||
| <body> | ||
| <div id="support-root"></div> | ||
| <div id="ui-root"></div> | ||
| <div id="avatar-ui-root"></div> |
There was a problem hiding this comment.
Each html file has a unique ui-root id as React 18 complains if we createRoot on an id more than once.
|
Hii @nikk15 I have migrated the src/react-components/avatar-editor.js to React 18, I need to do some final sanity on it before a PR, I'll put the link to PR here ... I think regarding the formatting, those spaces are probably generated by the Typescript formatter, Having Prettier as default formatter should solve most of the problems |
This reverts commit 6480836.
nickgrato
reviewed
Jun 14, 2023
| const width = el.offsetWidth; | ||
| const height = el.offsetHeight; | ||
| const ratio = height / width; | ||
| const scale = (CHAT_MESSAGE_TEXTURE_SIZE * Math.min(1.0, 1.0 / ratio)) / el.offsetWidth; |
There was a problem hiding this comment.
el.offsetWidth; could be "width"
nickgrato
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had hoped to upgrade Admin to React 18 also, but as there is a tangled web of packages relying on earlier versions of react, react-admin and material UI, I am leaving this for when we swap those components out for Lilypad.