Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize the nametag to fit the pronoun text #6141

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Conversation

keianhzo
Copy link
Contributor

@keianhzo keianhzo commented Jun 23, 2023

Currently the nametag pronoun overlaps with the volume bar. This PR makes the nametag to dynamically resize when there is a pronoun text to correctly show it.
Now:
Screenshot 2023-06-23 at 10 49 43Screenshot 2023-06-23 at 10 49 11
Before:
Screenshot 2023-06-23 at 10 53 48

Copy link
Contributor

@nikk15 nikk15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good catch :)

@keianhzo keianhzo merged commit 6aa7ca9 into master Jun 27, 2023
10 of 12 checks passed
@keianhzo keianhzo deleted the nametag-rearrange branch June 27, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants