Feature/robot hand gestures #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…but not at the correct speed and they don't interpolate between poses correctly.
robertlong
approved these changes
Mar 14, 2018
package.json
Outdated
| @@ -10,6 +10,7 @@ | |||
| "scripts": { | |||
| "postinstall": "node ./scripts/postinstall.js", | |||
| "start": "cross-env NODE_ENV=development webpack-dev-server", | |||
| "mobile" : "cross-env NODE_ENV=development webpack-dev-server --useLocalIp --host 0.0.0.0", | |||
There was a problem hiding this comment.
@brianpeiris is about to add something similar in his PR. You can probably remove this.
| this.playAnimation = this.playAnimation.bind(this); | ||
|
|
||
| // Get the three.js object in the scene graph that has the animation data | ||
| const root = this.el.querySelector("a-gltf-entity .RootScene").object3D.children[0]; |
There was a problem hiding this comment.
We talked briefly about creating our own animation-mixer component that we can add to the root scene element and other components such as this one can reference. I'll need that for implementing the eye animations. I think this is fine for this PR, let's talk more about it later.
| // console.log( | ||
| // `Animating ${isLeft ? "left" : "right"} hand from ${prevPose} to ${currPose} over ${duration} seconds.` | ||
| // ); | ||
| var from = mixer.clipAction(prevPose, this.root.parent); |
There was a problem hiding this comment.
Nit: change var to const
| // the optional root in `THREE.AnimationMixer.clipAction` and use the hierarchy | ||
| // preserved under the group (but not the node). Otherwise `clipArray` will be | ||
| // `null` in `THREE.AnimationClip.findByName`. | ||
| node.parent.animations = node.animations; |
There was a problem hiding this comment.
I still think this hack is crazy. Thanks, for documenting it. Hopefully we can find a more robust way of doing this in the future. This could screw up object3D.getObjectByName calls.
…long/social-vr-demo into feature/robot-hand-gestures
markusTraber
added a commit
to farvel-space/space-client
that referenced
this pull request
Sep 30, 2022
…y the 3d picture frame+hubsCloudSeptemberUpdate Merge in FAR/space-client from feature/FARM-225-integrate-and-deploy-the-3d-picture-frame+hubsCloudSeptemberUpdate to main * commit '117f37499b717c77ef03d56315a01dc78a4a8323': fixing scale setting issue for vertical images FARM-225: Fix clipboard has no farvel frame added check for buttonEl FARM-225: Added default asset. Added workaround for empty assetURL final stable form work Aug 28 Aug 20th work updated Aug 13 connection with spoke and stability edits Aug 7 functional prototype
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.