Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic blog integration #2

Merged
merged 16 commits into from
Oct 23, 2014

Conversation

patrickdavey
Copy link
Contributor

Adds some of the endpoints for Blog, BlogPost and Topics to hubspot-ruby.

I have slightly extended the utils class so that Time values can be passed, and that params which have range in their name (and which have a Range value passed) are correctly passed to the api.

Thanks for the great work putting this gem together 👍

Note, there was one failing test on master before starting this work, and it is still there. I have not investigated further:

 1) Contacts API Live test finds a contact by utk
     Failure/Error: Hubspot::Contact.find_by_utk("f844d2217850188692f2610c717c2e9b").should be_present
       expected present? to return true, got false
     # ./spec/live/contacts_integration_spec.rb:30:in `block (2 levels) in <top (required)>'
     # ./spec/support/cassette_helper.rb:5:in `block in extended'

@adimichele
Copy link
Contributor

Thanks so much for contributing! I'll merge...

Thanks also for the heads up about that test failure. I think there are some subtle dependencies on the Hubspot API, so hopefully this doesn't represent a code issue. I'll add an issue.

adimichele added a commit that referenced this pull request Oct 23, 2014
@adimichele adimichele merged commit 8eb0b4d into HubspotCommunity:master Oct 23, 2014
@patrickdavey
Copy link
Contributor Author

Glad you liked the pull request :)

Will you be putting out a new release of the gem so that I can update the bundle to point back to your gem rather than my branch on github?

@adimichele
Copy link
Contributor

Just pushed!

BTW, I'm not actively maintaining this gem anymore - if you're planning to do more work on it I'd be happy to make you a committer/gem owner.

@patrickdavey
Copy link
Contributor Author

Hi Andrew,

At the moment we're not planning on doing more integrating with hubspot
than what I did for this gem. If that changes and we do more then I'd be
very happy to become a committer / gem owner :)

Best,
Patrick

On 28 October 2014 11:56, Andrew DiMichele notifications@github.com wrote:

Just pushed!

BTW, I'm not actively maintaining this gem anymore - if you're planning to
do more work on it I'd be happy to make you a committer/gem owner.


Reply to this email directly or view it on GitHub
#2 (comment)
.

http://blog.psdavey.com

dan987 pushed a commit that referenced this pull request Jun 26, 2016
…roperties_schema_110440394

Feature/get and set contact properties schema 110440394
karimmtarek added a commit to karimmtarek/hubspot-ruby that referenced this pull request Jul 26, 2016
dan987 added a commit that referenced this pull request Oct 27, 2016
bnorton referenced this pull request in chamaeleonidae/hubspot-ruby Jun 8, 2017
Added an OAuth class for refreshing/creating.
jplot referenced this pull request in lounna-team/hubspot-api-ruby Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants