T #11 Added custom service scope #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaisoBits
reviewed
Aug 21, 2022
|
|
||
| protected virtual void Dispose(bool disposing) | ||
| { | ||
| if (disposing) AsyncScope.Dispose(); |
There was a problem hiding this comment.
I think you want to call .Dispose on the AsyncScope regardless of the disposing value
Otherwise if we don't explicitly call Dispose on this object (or via using), the AsyncScope won't get disposed by the finalizer.
There was a problem hiding this comment.
As for now, this is intended, there should not be a place anywhere in the code where ExtendedShardedInteractionContext is not disposed of. Although we should watch it and see what happens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
T #11