Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navbar: add a language chooser #151

Merged
merged 5 commits into from
Apr 16, 2017

Conversation

ronnychevalier
Copy link
Contributor

Add a dropdown menu in the navbar when there is translations available
for a page.

It only supports currently supported languages from the i8n/ folder.
For each new translation in the i8n/ folder, a new mapping must be
added in native_names.yaml.

See #67

ronnychevalier and others added 4 commits April 12, 2017 20:34
Add a dropdown menu in the navbar when there is translations available
for a page.

It only supports currently supported languages from the i8n/ folder.
For each new translation in the i8n/ folder, a new mapping must be
added in native_names.yaml.

See HugoBlox#67
- add "nl" option from recently merged PR
- change "zh" value to be consistent with that used by Google
@gcushen
Copy link
Collaborator

gcushen commented Apr 15, 2017

Thank you very much for implementing all the remaining multi-lingual features from issue #67 😃

I agree that using Font Awesome's language icon makes a lot of sense. However, many of the most popular sites like Facebook and Microsoft use a globe icon to represent their language choosers, so I have updated the PR to be consistent with their approach.

Also, I have updated the native zh value to be consistent with how Google and Facebook refer to Simplified Chinese.

Perhaps it might be worth considering renaming lang in the path to i18n since this is all related to i18n?

@ronnychevalier
Copy link
Contributor Author

Sure, all is fine for me :)

Thanks

@gcushen
Copy link
Collaborator

gcushen commented Apr 15, 2017

OK, do you want to rename data/lang/native_names.yaml to data/i18n/native_names.yaml or maybe even data/i18n/languages.yaml? Unless you think the original path is better?

@gcushen gcushen merged commit d5c27af into HugoBlox:master Apr 16, 2017
@gcushen
Copy link
Collaborator

gcushen commented Apr 16, 2017

Thank you very much @ronnychevalier :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants