Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes the password handling in the wizard and allow access to the db via unix sockets #132

Merged
merged 2 commits into from Sep 11, 2023
Merged

Fixes the password handling in the wizard and allow access to the db via unix sockets #132

merged 2 commits into from Sep 11, 2023

Conversation

hangug-eo
Copy link

No description provided.

@HugoFara HugoFara added enhancement Develop an existing feature database Database-related issues labels Sep 11, 2023
HugoFara added a commit that referenced this pull request Sep 11, 2023
@HugoFara
Documents PR #132.
69e82c1
@HugoFara HugoFara merged commit dd4a9a7 into HugoFara:master Sep 11, 2023
4 checks passed
@HugoFara
Copy link
Owner

Hi! I made some thinking, as you have two different things in your PR:

  • A fix for the database wizard not saving password: that is accepted right away.
  • A new feature to choose a custom socket. I made some thinking about the risks of backward incompatibility and edited your commit. Now it is backward compatible, and it may be useful, so I finally accepted it.

I'm thinking about adding a port customization option as well. Sorry for having kept you waiting!

@HugoFara HugoFara added the bug Something isn't working label Sep 11, 2023
HugoFara added a commit that referenced this pull request Sep 12, 2023
@HugoFara
Merge branch 'master' into dev.
a61d8df 
Fixes #140 and #132.
Adds new feature from #132.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working database Database-related issues enhancement Develop an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hangug-eo @HugoFara