Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old theme and enhance Test page frontend #154

Closed
wants to merge 26 commits into from

Conversation

ProgramComputer
Copy link

@ProgramComputer ProgramComputer commented Oct 4, 2023

View it here https://programcomputer.github.io/lwt/docs/info.html. Floating.js is added back. Test page footer and resizing has been changed to be more responsive. Text page is not affected.
Screenshot 2023-12-26 131139

@ProgramComputer ProgramComputer changed the title Clean up info.html and bring back floating.js Old theme and bring back floating.js Oct 5, 2023
@ProgramComputer ProgramComputer marked this pull request as draft October 7, 2023 04:55
@ProgramComputer ProgramComputer marked this pull request as ready for review October 9, 2023 07:41
@ProgramComputer ProgramComputer changed the title Old theme and bring back floating.js Old theme and enhance Test page Dec 25, 2023
@ProgramComputer ProgramComputer changed the title Old theme and enhance Test page Old theme and enhance Test page frontend Dec 25, 2023
@HugoFara HugoFara added ui Any problem related to the User Interface ux User Experience could be better labels Dec 31, 2023
@HugoFara HugoFara added the invalid This doesn't seem right label Jan 5, 2024
@HugoFara
Copy link
Owner

HugoFara commented Jan 5, 2024

Hi, they are many different things in this PR, some I don't want:

  • Reintroducing floating: I don't see the point, I think it's distracting and not useful (it prevents reading while scrolling).
  • Test page resizing: both test page header and footer have very few content. I'm not sure of why you want to add the resizing option.
  • Test page footer: what are the changes exactly? You do not explain in your comment 😶

For now I will close as this PR affects too many things, I'm open to discuss each point separately though!

@HugoFara HugoFara closed this Jan 5, 2024
@ProgramComputer
Copy link
Author

ProgramComputer commented Jan 5, 2024

Hi, they are many different things in this PR, some I don't want:

  • Reintroducing floating: I don't see the point, I think it's distracting and not useful (it prevents reading while scrolling).
  • Test page resizing: both test page header and footer have very few content. I'm not sure of why you want to add the resizing option.
  • Test page footer: what are the changes exactly? You do not explain in your comment 😶

For now I will close as this PR affects too many things, I'm open to discuss each point separately though!

Did you take a look at https://programcomputer.github.io/lwt/docs/info.html? It brings more info in index.php. The footer takes up space from the dictionary iframe.
Screenshot 2024-01-05 100640

@HugoFara
Copy link
Owner

HugoFara commented Jan 5, 2024

Did you take a look at https://programcomputer.github.io/lwt/docs/info.html?

I did, and I'm still not convinced 😄

It brings more info in index.php.

What do you mean?

The footer takes up space from the dictionary iframe.

I'm planning to remove the top-up iframe (#166), I'm not against this change, but there will be a more foundational change so let's after that what we do...

@ProgramComputer
Copy link
Author

What do you mean?

See the picture attached.
This was in the original lwt.

@HugoFara
Copy link
Owner

HugoFara commented Jan 5, 2024

I moved this information to server_data.php:

  • It's cleaner
  • It's easier to copy/paste when sending issue
  • We can add more information

So I removed it from the footer 😄

@ProgramComputer
Copy link
Author

ProgramComputer commented Jan 5, 2024

@HugoFara What do you think of the header being closer?
Screenshot 2024-01-05 111958

@HugoFara
Copy link
Owner

HugoFara commented Jan 5, 2024

Do you mean the header?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right ui Any problem related to the User Interface ux User Experience could be better
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants