Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON URL Setup Mode #88

Merged
merged 4 commits into from
Aug 21, 2019
Merged

JSON URL Setup Mode #88

merged 4 commits into from
Aug 21, 2019

Conversation

HugoGresse
Copy link
Owner

#80

@HugoGresse HugoGresse added the enhancement New feature or request label Aug 19, 2019
@HugoGresse HugoGresse self-assigned this Aug 19, 2019
src/core/setupType/projectApi.js Show resolved Hide resolved
src/core/setupType/projectApi.js Show resolved Hide resolved
src/core/setupType/projectApi.js Show resolved Hide resolved
src/core/setupType/projectApi.js Show resolved Hide resolved
src/core/setupType/projectApi.js Show resolved Hide resolved
}
}

getJsonData(state) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'state' is defined but never used no-unused-vars

firebase.initializeApp(config, config.projectId)
}

getFirestore = state => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parsing error: Unexpected token =

@HugoGresse HugoGresse merged commit ee4cf14 into master Aug 21, 2019
@HugoGresse HugoGresse deleted the #80-json-file-link branch August 21, 2019 11:14
@HugoGresse HugoGresse mentioned this pull request Aug 21, 2019
3 tasks
HugoGresse added a commit that referenced this pull request Sep 19, 2019
* Base implem

* 2 todos done

* Minor review change

* Fix Header See event link to keep current domain
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant