Skip to content

Commit

Permalink
tests/kola: bump minDisk in autosave-xfs tests
Browse files Browse the repository at this point in the history
The actual agcount on a 64G disk depends on the agsize baked in the
image, which in turn depends on how large the rootfs was calculated to
be (see `estimate-commit-disk-size` in cosa).

Since the starting rootfs size will differ on different arches (notably,
be larger than x86_64) and minor variations are greatly amplified, the
agcount may be lower than expected for a 64G disk and in turn the test
can fail. Even on x86_64, the rootfs size can change e.g. in CI builds
where we bake non-stripped binaries.

Bump the requested disk size to 100G in the test to make it more
foolproof.

Closes: coreos/fedora-coreos-tracker#1458
  • Loading branch information
jlebon authored and HuijingHei committed Oct 10, 2023
1 parent ef56e6a commit 9ba0d83
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 14 deletions.
12 changes: 0 additions & 12 deletions kola-denylist.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,15 +34,3 @@
snooze: 2023-04-12
arches:
- aarch64
- pattern: ext.config.root-reprovision.autosave-xfs
tracker: https://github.com/coreos/fedora-coreos-tracker/issues/1458
snooze: 2023-04-21
arches:
- aarch64
- ppc64le
- pattern: ext.config.root-reprovision.luks.autosave-xfs
tracker: https://github.com/coreos/fedora-coreos-tracker/issues/1458
snooze: 2023-04-21
arches:
- aarch64
- ppc64le
2 changes: 1 addition & 1 deletion tests/kola/root-reprovision/autosave-xfs/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
## # This test reprovisions the rootfs automatically.
## tags: "platform-independent reprovision"
## # Trigger automatic XFS reprovisioning
## minDisk: 64
## minDisk: 100
## # Root reprovisioning requires at least 4GiB of memory.
## minMemory: 4096
## # This test includes a lot of disk I/O and needs a higher
Expand Down
2 changes: 1 addition & 1 deletion tests/kola/root-reprovision/luks/autosave-xfs/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
## # timeout value than the default.
## timeoutMin: 15
## # Trigger automatic XFS reprovisioning
## minDisk: 64
## minDisk: 100

set -xeuo pipefail

Expand Down

0 comments on commit 9ba0d83

Please sign in to comment.