Cleanup and Audit - HBOT

[Rixxan]

As part of 1.6, the existing code in this repository should be reviewed.

• Is all code in line with PEP8 Standards?
• Is all code as efficient as possible?
• What errors, if any, are present in the current code?
• Are any unused assets removed?
• What can be done to improve the documentation?
• What can be done to improve the speed and performance of the bot?

[Rixxan]

In GitLab by @rik079 on Jan 13, 2022, 07:01

I'm working on a list of all things that, in my opinion, need to be looked at. Basically all band-aids, quick-fixes, and workarounds that were added in and would probably not suffice for the next stage we are entering with this project.

[Rixxan]

In GitLab by @rik079 on Jan 13, 2022, 07:02

marked the checklist item Is all code in line with PEP8 Standards? as completed

[Rixxan]

In GitLab by @rik079 on Jan 13, 2022, 07:02

marked the checklist item Is all code in line with PEP8 Standards? as incomplete

[Rixxan]

A few things noticed in 1.5 pre-launch review:

• Notify needs a dict/tuple (see !114)
• Fact Module/holdout inline help's need moved to unified help sys (but not critical as admin+ only commands)

[Rixxan]

SKAUDOAE UF-Q B47-1 is failing and shouldn't. TODO.

[Rixxan]

In GitLab by @rik079 on Mar 27, 2022, 19:29

I think we can now safely assert that with probability bordering on certainty all code is now PEP-8 compliant and new code will remain so?

[Rixxan]

Agreed as of ee5bc97

[Rixxan]

marked the checklist item Is all code in line with PEP8 Standards? as completed

[Rixxan]

marked the checklist item Are any unused assets removed? as completed

[Rixxan]

mentioned in commit 2da9cb2

[Rixxan]

Should we consider replacing our current DB stuff (ref #91 ) with SQLAlchemy? Apparently that library autocaches things.

[Rixxan]

Second thought would love to have a Docker-type system that's already set up for testing with a basic DB that responds how the bot is expecting, even if it doesn't contain the proper schema.

[Rixxan]

The majority of the updates we want for 1.6.0 are done, with the exception of Pydle 1.0 which is currently awaiting review and release: shizmob/pydle#176

New features such as the above comments will wait for later. Updates pending found in !135.

Once Pydle releases we should be ~ 1 week from release.

[Rixxan]

marked the checklist item Is all code as efficient as possible? as completed

[Rixxan]

marked the checklist item What errors, if any, are present in the current code? as completed

[Rixxan]

1.6.0 released, working on further enhancements and reviews for 1.6.1.

[Rixxan]

With !142, we will have had 3 passes on HBOT to iron out issues. Remaining known issues have been assigned to their own issues, the main issue here can be closed safely and allow us to move on to other tasks.