v1.0.0 #176
Merged
v1.0.0 #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix use of mutable default arguments
According to current IRCv3 documentation, server support for `monitor` is indicated in `RPL_ISUPPORT`, and not in capability negotiation.
Per spec, servers are allowed to send a full `nick!user@host` mask instead of just a nickname in `RPL_MON*` replies.
Co-authored-by: Joshua Salzedo <thHunkn0WNd@gmail.com>
Fixes a documentation async/await typo
Fix parsing IRCv3 tags with missing/empty values
`monitor` support fixes
Correct a typo in features/overview.rst
[#151] Fixup irccat.py example
Enable RplWhoisHostSupport implementation
[#161] Remove Deprecated Marker from WHOIS
Temp Patch that should probably be dealt with sooner rather than later.
Found these on manual checks :)
[#159] Fix Missing Awaits in various files
- for those who prefer not subclassing.
Yeah I shouldn't touch this until I completely understand it.
Remove unused exception variable, mark several methods static, remove arguments equal to default, numerous spacing and PEP8 Updates, add missing awaits to various functions, condense dictionary declaration, update test for membership
As requested in review.
As Requested
Adds ... to ABC, undos adding of asyncs, reverts staticmethod changes
Found in #169 update, including in own PR per request
Pydle does not, as of v0.9.4, support Python 3.10 (Ref #162). This change makes this clear in the documentation and could be reverted once proper support for 3.10 has been implemented.
Python 3.10 is not yet supported (Ref #162)
Updated versioning
Update supported versions as of v0.9.4
Add Missing awaits in coroutine calls
Per Requests, removing the mock event loop. Pydle no longer rolls its own event loop, because Pydle is a good little program.
This segment was causing all sorts of "was not awaited" warnings, however removing it seems to have resolved these issues. I think it's an artefact from when Pydle was running its own event loop.
…cord_like_event_registration Implement decorator-based event handler registration
Update Test Library
As Requested, to convey intent better regardless of default status.
Formatting updates
Poetry migration
|
As per SEMVER, #144 Changes the public API in a backward-incompatable way. I think this incurs the SEMVER major release rule. |
Rixxan
suggested changes
Jun 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major changes
monitorsupport fixes #144monitorandunmonitorare nowasync deffunctionsBug Fixes
Features
Misc