Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CreateComment resolver #1038

Merged
merged 1 commit into from Jul 13, 2019
Merged

Refactor CreateComment resolver #1038

merged 1 commit into from Jul 13, 2019

Conversation

mattwr18
Copy link
Member

  • extract out the validations for a valid comment

🍰 Pullrequest

Issues

@mattwr18
Refactor CreateComment resolver
ba7e44a 
- extract out the validations for a valid comment
@codecov
Copy link

codecov bot commented Jul 12, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@bd77c8e). Click here to learn what that means.
The diff coverage is n/a.

roschaefer
roschaefer approved these changes Jul 13, 2019
View reviewed changes
Copy link
Contributor

@roschaefer roschaefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@roschaefer roschaefer merged commit 0d06b78 into master Jul 13, 2019
@roschaefer roschaefer deleted the 1037-refactor-comments-resolver-extract-out-validations branch July 13, 2019 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roschaefer roschaefer roschaefer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Refactor] CreateComment validations to validations middleware
2 participants
@mattwr18 @roschaefer