Silence codecov #1043
Merged
Silence codecov #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our fellow @Hardy-Peaceglobal already turned off Github's notifications completely because of codecov's PR comments. I think it's more important not to annoy open-source contributors than to have these comments.
Codecov Report
|
ogerly
approved these changes
Jul 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍰 Pullrequest
Recently, codecov was spamming our PRs with useless comments. I think this is the moment, when we could disable codecov comments without worrying. There is also reason for disabling the comments even if they would show a valid code coverage: People just get annoyed and start to turn off Github notifications.
Issues
Todo